Quickly update the tutor about your iP progress:
Level-10
(i.e., the GUI) and A-Gradle
? Any GUIs that went beyond the JavaFx tutorial?This activity is to be done as a team. One team member needs to be connected to the TV.
Updated instructions: Review PRs of the other team. You can find the team information from here.
Team allocation for the code quality discussion
Team | Discuss PRs of |
---|---|
Team 1 | Team 2 |
Team 2 | Team 1 |
Team 3 | Team 4 |
Team 4 | Team 3 |
Locate PRs from that team: Go to the list of Duke PRs. Locate the PRs (you can filter using tutorial.*
and team.*
labels).
Pick a PR to review, giving priority to PRs with fewer comments.
Discuss abstraction aspect of the code: Go through the code, and discuss the abstraction (SLAP, arrow-head style code, too-long methods, too-deep nesting) aspect of the PR
To identify long methods or deep nesting, zoom out and scroll through the entire PR code to do a visual inspection (no need to read the code line-by-line). After visually locating a method that looks too long/deep, have a closer look to see it can be improved by using better abstraction.If you are unsure about a case, you can also rope the tutor in to the discussion.
Add comments: If the team agrees that the abstraction aspect of specific piece of code should be improved some way, add a comment (team members can take turns on adding comments).
e.g., This method looks rather long; perhaps it can be shortened using SLAP?
Repeat for remaining PRs: Continue to review PRs until the 20 minutes mark.
After the tutorial, you can apply the insights gained from this activity to improve the code quality of your own iP, if necessary.