- Review some peer PRs
- Add Increments as parallel branches:
A-Gradle,A-CheckStyle,Level-10,A-Varargs
1 Review some peer PRs
- Review two PRs created by your classmates. PRs can be found here.
- The allocation of which PRs to review will be specified in this page (you will be notified when the allocation is ready).
- To find the target PR, you can use a filter
author:AuthorUsernamee.g.,author:johnDoe - If the student you have been allocated to review has not created a PR by Monday, you can review another PR of your choice.
We expect the PR peer-review to be mutually beneficial to the reviewer and the author. i.e., you receive suggestions on how to improve your code, and get to learn alternative designs by reading others' code.
- Read up the following guidelines:
Admin Using GitHub → Guidelines for Reviewing PRs
-
Additional guidelines:
- Comment on coding standard violations.
- At the end of the review, we recommend you to choose
Comment(i.e., notApproveorRequest changes)
-
Use the iP Code Dashboard to view others' code: You can now easily view iP code written by classmates, using the
Links → iP Code Dashboarditem in the top navigation menu. Click on the </> icon corresponding to a student name to see the code written by that person. We encourage you to read others’ code and learn from them. If you adopt solutions from others (also encouraged), please follow our reuse policy.
Admin Module Policies → Policy on Reuse
2 Add Increments as parallel branches: A-Gradle, A-CheckStyle, Level-10, A-Varargs
- Do each enhancement in a separate branch and merge to the
masterbranch only when ready (if you push incomplete features into themasterbranch, it can confuse others reviewing your PR).
If you have completed any of them in previous weeks, just add the corresponding tag (no need to create a branch).
A-Gradle: Use Gradle Use Gradle to automate some of the build tasks of the project. Refer to the Gradle tutorial at the Duke repo (i.e., the repo you forked from) to find how to set up Gradle for your project.
- Minimal: Set up gradle so that you can build and run Duke using gradle.
- Recommended: Set up gradle to run unit tests.
- Stretch Goal: Use gradle to automate more things in your project.
A-CheckStyle: Use CheckStyle optionalUse checkStyle to detect coding style violations.
If you are using Gradle for your project, refer to the Gradle tutorial at the Duke repo (i.e., the repo you forked from) to find how to use CheckStyle via Gradle. Alternatively, you can try the CheckStyle plugin for Intellij.
Extension A-Gradle
Use Gradle to automate some of the build tasks of the project. Refer to the Gradle tutorial at the Duke repo (i.e., the repo you forked from) to find how to set up Gradle for your project.
- Minimal: Set up gradle so that you can build and run Duke using gradle.
- Recommended: Set up gradle to run unit tests.
- Stretch Goal: Use gradle to automate more things in your project.